Re: [PATCH v2] perf: cs-etm: Improve missing sink warning message

From: Suzuki K Poulose
Date: Tue Jan 24 2023 - 06:08:49 EST


On 24/01/2023 11:02, James Clark wrote:
Make the sink error message more similar to the event error message that
reminds about missing kernel support. The available sinks are also
determined by the hardware so mention that too.

Also, usually it's not necessary to specify the sink, so add that as a
hint.

Now the error for a made up sink looks like this:

$ perf record -e cs_etm/@abc/
Couldn't find sink "abc" on event cs_etm/@abc/.
Missing kernel or device support?

Hint: An appropriate sink will be picked automatically if one isn't is specified.

For any error other than ENOENT, the same message as before is
displayed.

Signed-off-by: James Clark <james.clark@xxxxxxx>

Acked-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>