Re: [PATCH] mmc: core: expose MMC_CAP_AGGRESSIVE_PM to DT

[Ulf Hansson]

On Wed, 18 Jan 2023 at 05:57, Hermes Zhang <chenhuiz@xxxxxxxx> wrote:
>
> This patch expose the MMC_CAP_AGGRESSIVE_PM flag to DT which
> allows the host to enable it from DT.
>
> Signed-off-by: Hermes Zhang <chenhuiz@xxxxxxxx>
> ---
>  drivers/mmc/core/host.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index d17eda753b7e..1d98a301515d 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -376,6 +376,8 @@ int mmc_of_parse(struct mmc_host *host)
>                 host->caps |= MMC_CAP_HW_RESET;
>         if (device_property_read_bool(dev, "cap-sdio-irq"))
>                 host->caps |= MMC_CAP_SDIO_IRQ;
> +       if (device_property_read_bool(dev, "cap-aggressive-pm"))
> +               host->caps |= MMC_CAP_AGGRESSIVE_PM;

I think this can be debated whether this is a description of some
characteristics of the HW.

That said, please add the DT list and maintainers and resend, to let
them share their view too.

>         if (device_property_read_bool(dev, "full-pwr-cycle"))
>                 host->caps2 |= MMC_CAP2_FULL_PWR_CYCLE;
>         if (device_property_read_bool(dev, "full-pwr-cycle-in-suspend"))
> --

Kind regards
Uffe