Re: [PATCH v2 8/9] perf jevents: Generate metrics and events as separate tables

From: Ian Rogers
Date: Mon Jan 23 2023 - 23:49:42 EST


On Mon, Jan 23, 2023 at 7:18 AM John Garry <john.g.garry@xxxxxxxxxx> wrote:
>
> On 21/12/2022 22:34, Ian Rogers wrote:
> > Turn a perf json event into an event, metric or both. This reduces the
> > number of events needed to scan to find an event or metric. As events
> > no longer need the relatively seldom used metric fields, 4 bytes is
> > saved per event. This reduces the big C string's size by 335kb (14.8%)
> > on x86.
> >
> > Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>
>
> It would have been good to show an example of how the output changes. I
> could not apply the series (see cover), and knowing what to expect makes
> reviewing the code easier...
>
> Thanks,
> John

Thanks, will add in v3.

Ian