Re: [PATCH 4.19 00/37] 4.19.271-rc1 review

From: Guenter Roeck
Date: Mon Jan 23 2023 - 21:47:40 EST


On Sun, Jan 22, 2023 at 04:03:57PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.271 release.
> There are 37 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 24 Jan 2023 15:02:08 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 155 pass: 154 fail: 1
Failed builds:
i386:tools/perf
Qemu test results:
total: 426 pass: 426 fail: 0

perf build failure:

util/env.c: In function ‘perf_env__arch’:
cc1: error: function may return address of local variable [-Werror=return-local-addr]
util/env.c:166:17: note: declared here
166 | struct utsname uts;
| ^~~

No one to blame but me, for switching the gcc version used to build perf
to gcc 10.3.0 (from 9.4.0). The problem is fixed in the upstream kernel
with commit ebcb9464a2ae3 ("perf env: Do not return pointers to local
variables"). This patch applies to v5.4.y and earlier kernels.

I'll leave it up to you if you want to apply the fix or not; I'll be
happy to work around the problem in my tests otherwise. Either case,

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

since this is not a new problem.

Thanks,
Guenter