Re: [PATCH 2/2] drm: lcdif: Add i.MX93 LCDIF support

From: Marek Vasut
Date: Mon Jan 23 2023 - 10:57:34 EST


On 1/23/23 08:23, Liu Ying wrote:
The LCDIF embedded in i.MX93 SoC is essentially the same to those
in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI
controller through LCDIF cross line pattern(controlled by mediamix
blk-ctrl) or connect with LVDS display bridge(LDB) directly or a
parallel display(also through mediamix blk-ctrl), so add multiple
encoders(with DRM_MODE_ENCODER_NONE encoder type) support in the
LCDIF DRM driver and find a bridge to attach the relevant encoder's
chain when needed. While at it, derive lcdif_crtc_state structure
from drm_crtc_state structure to introduce bus_format and bus_flags
states so that the next downstream bridges may use consistent bus
format and bus flags.

Would it be possible to split this patch into preparatory clean up and i.MX93 addition ? It seems like the patch is doing two things according to the commit message.