Re: [PATCH v2 2/2] clk: qcom: Add Global Clock Controller (GCC) driver for SM7150

From: Krzysztof Kozlowski
Date: Mon Jan 23 2023 - 04:12:51 EST


On 22/01/2023 20:29, Danila Tikhonov wrote:
> Add support for the global clock controller found on SM7150
> based devices. This should allow most non-multimedia device
> drivers to probe and control their clocks.
>
> Co-developed-by: David Wronek <davidwronek@xxxxxxxxx>
> Signed-off-by: David Wronek <davidwronek@xxxxxxxxx>
> Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> drivers/clk/qcom/Kconfig | 8 +
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/gcc-sm7150.c | 3159 +++++++++++++++++++++++++++++++++
> 3 files changed, 3168 insertions(+)
> create mode 100644 drivers/clk/qcom/gcc-sm7150.c
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 5ab4b7dfe3c2..a0253d9b5695 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -759,6 +759,14 @@ config SM_GCC_6375
> Say Y if you want to use peripheral devices such as UART,
> SPI, I2C, USB, SD/UFS etc.
>
> +config SM_GCC_7150
> + tristate "SM7150 Global Clock Controller"
> + select QCOM_GDSC
> + help
> + Support for the global clock controller on SM7150 devices.
> + Say Y if you want to use peripheral devices such as UART,
> + SPI, I2C, USB, SD/UFS, PCIe etc.
> +
> config SM_GCC_8150
> tristate "SM8150 Global Clock Controller"
> help
> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> index 3194465dd02c..9da86c42e7fd 100644
> --- a/drivers/clk/qcom/Makefile
> +++ b/drivers/clk/qcom/Makefile
> @@ -107,6 +107,7 @@ obj-$(CONFIG_SM_GCC_6115) += gcc-sm6115.o
> obj-$(CONFIG_SM_GCC_6125) += gcc-sm6125.o
> obj-$(CONFIG_SM_GCC_6350) += gcc-sm6350.o
> obj-$(CONFIG_SM_GCC_6375) += gcc-sm6375.o
> +obj-$(CONFIG_SM_GCC_7150) += gcc-sm7150.o
> obj-$(CONFIG_SM_GCC_8150) += gcc-sm8150.o
> obj-$(CONFIG_SM_GCC_8250) += gcc-sm8250.o
> obj-$(CONFIG_SM_GCC_8350) += gcc-sm8350.o
> diff --git a/drivers/clk/qcom/gcc-sm7150.c b/drivers/clk/qcom/gcc-sm7150.c
> new file mode 100644
> index 000000000000..05bece700d19
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sm7150.c
> @@ -0,0 +1,3159 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2023, Danila Tikhonov <danila@xxxxxxxxxxx>
> + * Copyright (c) 2023, David Wronek <davidwronek@xxxxxxxxx>

Include original work copyrights...


Best regards,
Krzysztof