Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node

[Stefan Wiehler]

Hi Russell,

>> +	cn = of_get_cpu_node(cpu, NULL);
>> +	if (!cn)
>> +		pr_err("missing device node for CPU %d\n", cpu);
>> +	cn = of_get_parent(cn);
>
> Doesn't this need to do an of_node_put()?
>
>> +	if (!cn)
>> +		pr_err("missing parent node for CPU %d\n", cpu);
>> +	common_rate = of_get_property(cn, "clock-frequency", 
&common_rate_len);
>
> And here too?

I have sent v2 in the meanwhile where I have refactored this part; 
please review:

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221221154213.24382-1-stefan.wiehler@xxxxxxxxx/

Kind regards,

Stefan Wiehler