Re: [PATCH] cxl/mbox: Add debug messages for supported mailbox commands

From: Alison Schofield
Date: Mon Jan 23 2023 - 00:41:35 EST


On Thu, Jan 19, 2023 at 02:04:50PM +0100, Robert Richter wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of supported commands is useful too. Change debug messages to
> also report the opcodes of supported commands.

Hi Robert,
I wonder if you can get this info another way. When I try this
loading cxl_test today, I get 99 new messages. Is this going to
create too much noise with debug kernels?
Alison

>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@xxxxxxx>
> ---
> drivers/cxl/core/mbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a48ade466d6a..ffa9f84c2dce 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
>
> if (!cmd) {
> dev_dbg(cxlds->dev,
> - "Opcode 0x%04x unsupported by driver", opcode);
> + "Opcode 0x%04x unsupported by driver\n", opcode);
> continue;
> }
>
> set_bit(cmd->info.id, cxlds->enabled_cmds);
> + dev_dbg(cxlds->dev, "Opcode 0x%04x supported by driver\n", opcode);
> }
> }
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> --
> 2.30.2
>