Re: [PATCH v2] paride/pcd: return earlier when an error happens in pcd_atapi()

From: Jens Axboe
Date: Sun Jan 22 2023 - 15:50:10 EST


On 1/22/23 8:49 AM, Tom Rix wrote:
> clang static analysis reports
> drivers/block/paride/pcd.c:856:36: warning: The left operand of '&'
> is a garbage value [core.UndefinedBinaryOperatorResult]
> tocentry->cdte_ctrl = buffer[5] & 0xf;
> ~~~~~~~~~ ^

Has this one been compiled? I'm guessing not tested...

In any case, this code is going away hopefully shortly, so let's not
bother with changes like this.

--
Jens Axboe