Re: [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

From: Rayyan Ansari
Date: Sun Jan 22 2023 - 12:28:38 EST


On 22/01/2023 15:31, Rob Herring wrote:

On Sat, 21 Jan 2023 15:35:44 +0000, Rayyan Ansari wrote:
Signed-off-by: Rayyan Ansari <rayyan@xxxxxxxxx>
---
.../devicetree/bindings/display/simple-framebuffer.yaml | 8 ++++++++
1 file changed, 8 insertions(+)


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/simple-framebuffer.yaml: properties:width-mm: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/simple-framebuffer.yaml: properties:height-mm: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230121153544.467126-3-rayyan@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


I will remove the $ref property in v2, but I will also wait if there is any other feedback to address.

--
Rayyan Ansari
https://ansari.sh