Re: [RFC PATCH v2 0/5] iio: adc: qcom-spmi-vadc: Propagate fw node label to userspace

[Jonathan Cameron]

On Mon, 16 Jan 2023 23:09:04 +0100
Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote:

> Implement read_label in qcom-spmi-vadc to see DT-specified label names
> in userspace.  At the same time clear up some documentation around
> extend_name to promote read_label, and normalize similar code in
> qcom-spmi-adc5.
> 

I think this is a good route forwards, but it is making changes
to ABI so I definitely want input on this from at least one of
the qualcomm maintainers before I pick it up - particularly
the changes in patch 3.

Don't want to cause anyone nasty surprises.

J

> Changes since v1:
> - qcom-spmi-vadc: Use read_label instead of extend_name;
> 
> New since v1:
> - core: Point users of extend_name field to read_label callback
> - qcom-spmi-adc5: Use datasheet_name string literal for
>   iio_chan_spec::datasheet_name;
> - qcom-spmi-adc5: Fall back to datasheet_name instead of
>   fwnode_get_name() for iio_chan_spec::extend_name (gets rid of @xx in
>   sysfs filenames and labels);
> - qcom-spmi-adc5: Remove unnecessary datasheet_name NULL check.
> 
> v1: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@xxxxxxxxxxxxxx/
> 
> Marijn Suijten (5):
>   iio: core: Point users of extend_name field to read_label callback
>   iio: adc: qcom-spmi-adc5: Use driver datasheet_name instead of DT
>     label
>   iio: adc: qcom-spmi-adc5: Fall back to datasheet_name instead of
>     fwnode name
>   iio: adc: qcom-spmi-adc5: Remove unnecessary datasheet_name NULL check
>   iio: adc: qcom-spmi-vadc: Propagate fw node label to userspace
> 
>  drivers/iio/adc/qcom-spmi-adc5.c | 15 +++++++--------
>  drivers/iio/adc/qcom-spmi-vadc.c | 19 ++++++++++++++++++-
>  include/linux/iio/iio.h          |  3 +++
>  3 files changed, 28 insertions(+), 9 deletions(-)
> 
> --
> 2.39.0
>