Re: [PATCH v2 2/2] ASoC: dt-bindings: google,sc7280-herobrine: Add platform property

From: Krzysztof Kozlowski
Date: Sun Jan 22 2023 - 06:42:11 EST


On 20/01/2023 11:31, Srinivasa Rao Mandadapu wrote:
> Add platform property in sc7280 machine driver bindings for including
> platform subnode in dai-links.
> This is required for binding the frontend dai driver with codec driver
> and cpu driver and to do dynamic pcm routing in ADSP based platforms.

I have doubts that this is for binding frontend driver with codec and
CPU. The CPU and codec phandles are already there, so they are bound...

>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> index 869b403..0b1a01a 100644
> --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> @@ -75,6 +75,18 @@ patternProperties:
>
> additionalProperties: false
>
> + platform:
> + description: Holds subnode which includes the phandle of q6apm platform device.
> + type: object
> + properties:
> + sound-dai:
> + maxItems: 1
> +
> + required:
> + - sound-dai
> +
> + additionalProperties: false
> +
> required:
> - link-name
> - cpu

Add it also to existing example.


Best regards,
Krzysztof