[RFC PATCH v3 00/31] TDX KVM selftests

[Ackerley Tng]

Hello,

This is v3 of the patch series for TDX selftests.

It has been updated for Intel’s V10 of the TDX host patches which was
proposed in https://lkml.org/lkml/2022/8/8/877

The tree can be found at
https://github.com/googleprodkernel/linux-cc/tree/tdx-selftests-rfc-v3/

Changes from RFC v2:

Selftest setup now builds upon the KVM selftest framework when setting
up the guest for testing. We now use the KVM selftest framework to
build the guest page tables and load the ELF binary into guest memory.

Inlining of the entire guest image is no longer required and that
allows us to cleanly separate code into different compilation units
and be able to use proper assembly instead of inline assembly
(addresses Sean’s comment).

To achieve this, we take a dependency on the SEV VM tests:
https://lore.kernel.org/lkml/20221018205845.770121-1-pgonda@xxxxxxxxxx/T/. Those
patches provide functions for the host to allocate and track protected
memory in the guest.

In RFCv3, TDX selftest code is organized into:

+ headers in tools/testing/selftests/kvm/include/x86_64/tdx/
+ common code in tools/testing/selftests/kvm/lib/x86_64/tdx/
+ selftests in tools/testing/selftests/kvm/x86_64/tdx_*

RFCv3 also adds additional selftests for UPM.

Dependencies

+ Peter’s patches, which provide functions for the host to allocate
  and track protected memory in the
  guest. https://lore.kernel.org/lkml/20221018205845.770121-1-pgonda@xxxxxxxxxx/T/
+ Peter’s patches depend on Sean’s patches:
    + https://lore.kernel.org/linux-arm-kernel/20220825232522.3997340-1-seanjc@xxxxxxxxxx/T/
    + https://lore.kernel.org/lkml/20221006004512.666529-1-seanjc@xxxxxxxxxx/T/
+ Proposed fixes for these these issues mentioned on the mailing list
    + https://lore.kernel.org/lkml/36cde6d6-128d-884e-1447-09b08bb5de3d@xxxxxxxxx/
    + https://lore.kernel.org/lkml/diqzedtubs0d.fsf@xxxxxxxxxx/
    + https://lore.kernel.org/lkml/67b782ee-c95c-d6bc-3cca-cdfe75f4bf6a@xxxxxxxxx/
    + https://lore.kernel.org/lkml/diqzcz7cd983.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
    + https://lore.kernel.org/linux-mm/20221116205025.1510291-1-ackerleytng@xxxxxxxxxx/

Further work for this patch series/TODOs

+ Sean’s comments for the non-confidential UPM selftests patch series
  at https://lore.kernel.org/lkml/Y8dC8WDwEmYixJqt@xxxxxxxxxx/T/#u apply
  here as well
+ Add ucall support for TDX selftests

I would also like to acknowledge the following people, who helped
review or test patches in RFCv1 and RFCv2:

+ Sean Christopherson <seanjc@xxxxxxxxxx>
+ Zhenzhong Duan <zhenzhong.duan@xxxxxxxxx>
+ Peter Gonda <pgonda@xxxxxxxxxx>
+ Andrew Jones <drjones@xxxxxxxxxx>
+ Maxim Levitsky <mlevitsk@xxxxxxxxxx>
+ Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
+ David Matlack <dmatlack@xxxxxxxxxx>
+ Marc Orr <marcorr@xxxxxxxxxx>
+ Isaku Yamahata <isaku.yamahata@xxxxxxxxx>

Links to earlier patch series

+ RFC v1: https://lore.kernel.org/lkml/20210726183816.1343022-1-erdemaktas@xxxxxxxxxx/T/#u
+ RFC v2: https://lore.kernel.org/lkml/20220830222000.709028-1-sagis@xxxxxxxxxx/T/#u

Ackerley Tng (14):
  KVM: selftests: Add function to allow one-to-one GVA to GPA mappings
  KVM: selftests: Expose function that sets up sregs based on VM's mode
  KVM: selftests: Store initial stack address in struct kvm_vcpu
  KVM: selftests: Refactor steps in vCPU descriptor table initialization
  KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs'
    attribute configuration
  KVM: selftests: Require GCC to realign stacks on function entry
  KVM: selftests: Add functions to allow mapping as shared
  KVM: selftests: Add support for restricted memory
  KVM: selftests: TDX: Update load_td_memory_region for VM memory backed
    by restricted memfd
  KVM: selftests: Expose _vm_vaddr_alloc
  KVM: selftests: TDX: Add support for TDG.MEM.PAGE.ACCEPT
  KVM: selftests: TDX: Add support for TDG.VP.VEINFO.GET
  KVM: selftests: TDX: Add TDX UPM selftest
  KVM: selftests: TDX: Add TDX UPM selftests for implicit conversion

Erdem Aktas (4):
  KVM: selftests: Add support for creating non-default type VMs
  KVM: selftests: Add helper functions to create TDX VMs
  KVM: selftests: TDX: Add TDX lifecycle test
  KVM: selftests: TDX: Adding test case for TDX port IO

Roger Wang (1):
  KVM: selftests: TDX: Add TDG.VP.INFO test

Ryan Afranji (2):
  KVM: selftests: TDX: Verify the behavior when host consumes a TD
    private memory
  KVM: selftests: TDX: Add shared memory test

Sagi Shahar (10):
  KVM: selftests: TDX: Add report_fatal_error test
  KVM: selftests: TDX: Add basic TDX CPUID test
  KVM: selftests: TDX: Add basic get_td_vmcall_info test
  KVM: selftests: TDX: Add TDX IO writes test
  KVM: selftests: TDX: Add TDX IO reads test
  KVM: selftests: TDX: Add TDX MSR read/write tests
  KVM: selftests: TDX: Add TDX HLT exit test
  KVM: selftests: TDX: Add TDX MMIO reads test
  KVM: selftests: TDX: Add TDX MMIO writes test
  KVM: selftests: TDX: Add TDX CPUID TDVMCALL test

 tools/testing/selftests/kvm/.gitignore        |    3 +
 tools/testing/selftests/kvm/Makefile          |   10 +-
 .../selftests/kvm/include/kvm_util_base.h     |   43 +-
 .../testing/selftests/kvm/include/test_util.h |    2 +
 .../selftests/kvm/include/x86_64/processor.h  |    4 +
 .../kvm/include/x86_64/tdx/td_boot.h          |   82 +
 .../kvm/include/x86_64/tdx/td_boot_asm.h      |   16 +
 .../selftests/kvm/include/x86_64/tdx/tdcall.h |   59 +
 .../selftests/kvm/include/x86_64/tdx/tdx.h    |   65 +
 .../kvm/include/x86_64/tdx/tdx_util.h         |   19 +
 .../kvm/include/x86_64/tdx/test_util.h        |  164 ++
 tools/testing/selftests/kvm/lib/kvm_util.c    |  123 +-
 tools/testing/selftests/kvm/lib/test_util.c   |    7 +
 .../selftests/kvm/lib/x86_64/processor.c      |   77 +-
 tools/testing/selftests/kvm/lib/x86_64/sev.c  |    2 +-
 .../selftests/kvm/lib/x86_64/tdx/td_boot.S    |  101 ++
 .../selftests/kvm/lib/x86_64/tdx/tdcall.S     |  158 ++
 .../selftests/kvm/lib/x86_64/tdx/tdx.c        |  231 +++
 .../selftests/kvm/lib/x86_64/tdx/tdx_util.c   |  562 +++++++
 .../selftests/kvm/lib/x86_64/tdx/test_util.c  |  101 ++
 .../kvm/x86_64/tdx_shared_mem_test.c          |  137 ++
 .../selftests/kvm/x86_64/tdx_upm_test.c       |  460 ++++++
 .../selftests/kvm/x86_64/tdx_vm_tests.c       | 1329 +++++++++++++++++
 23 files changed, 3709 insertions(+), 46 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/td_boot.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/td_boot_asm.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/tdcall.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/tdx_util.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/tdx/td_boot.S
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c
 create mode 100644 tools/testing/selftests/kvm/x86_64/tdx_shared_mem_test.c
 create mode 100644 tools/testing/selftests/kvm/x86_64/tdx_upm_test.c
 create mode 100644 tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c

--
2.39.0.246.g2a6d74b583-goog