Re: [PATCH] ver_linux: add missing software to checklist

[Shuah Khan]

On 1/16/23 05:26, Alexander Kapshuk wrote:
> On Tue, Jan 10, 2023 at 11:13 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
> > Update to add missing software checks to bring it in sync with the
> > Documentation/Changes list. Make improvements to the output with
> > separator between different sections.
> >
> > Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > ---
> >   scripts/ver_linux | 29 ++++++++++++++++++++++++++---
> >   1 file changed, 26 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/ver_linux b/scripts/ver_linux
> > index 1a8ee4ff0e32..6131f6f1b35b 100755
> > --- a/scripts/ver_linux
> > +++ b/scripts/ver_linux
> > @@ -6,10 +6,14 @@
> >   # differ on your system.
> >
> >   BEGIN {
> > -       usage = "If some fields are empty or look unusual you may have an old version.\n"
> > -       usage = usage "Compare to the current minimal requirements in Documentation/Changes.\n"
> > +       usage = "Minimum required software versions to build and run current kernel version.\n"
> > +       usage = usage "If some fields are empty or look unusual you may have an old version.\n"
> > +       usage = usage "Compare with the current minimal requirements in Documentation/Changes.\n"
> >          print usage
> >
> > +       separator = "===================================================\n"
>
> Embedding a new line character at the start of the separator string
> would eliminate the need for the extra printf("\n") statements
> introduced.
>
> > +
> > +       print separator
> >          system("uname -a")
> >          printf("\n")
>
> Consequently, this printf could be removed as well.

Thank yo for your review. Will send v2 with your suggestions.

thanks,
-- Shuah