[PATCH 1/6] staging: rtl8192e: Combine three loops to one to init tx_pwr_level_...

From: Philipp Hortmann
Date: Fri Jan 20 2023 - 15:17:59 EST


The arrays EEPROMRfACCKChnl1TxPwLevel, EEPROMRfAOfdmChnlTxPwLevel,
EEPROMRfCCCKChnl1TxPwLevel, EEPROMRfCOfdmChnlTxPwLevel are initialized to
zero and never changed. The three loops contain the same code. Only the
index of the upper named arrays go from 0 to 2. Therefore the three loops
can be combined to one loop from 0 to 13 which removes useless code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
---
.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 22 +------------------
1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 227c13d552fc..7187ee4c75f6 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -426,7 +426,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
0xf0) >> 4;
} else if (priv->epromtype == EEPROM_93C56) {

- for (i = 0; i < 3; i++) {
+ for (i = 0; i < 14; i++) {
priv->tx_pwr_level_cck_a[i] =
priv->EEPROMRfACCKChnl1TxPwLevel[0];
priv->tx_pwr_level_ofdm_24g_a[i] =
@@ -436,26 +436,6 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
priv->tx_pwr_level_ofdm_24g_c[i] =
priv->EEPROMRfCOfdmChnlTxPwLevel[0];
}
- for (i = 3; i < 9; i++) {
- priv->tx_pwr_level_cck_a[i] =
- priv->EEPROMRfACCKChnl1TxPwLevel[1];
- priv->tx_pwr_level_ofdm_24g_a[i] =
- priv->EEPROMRfAOfdmChnlTxPwLevel[1];
- priv->tx_pwr_level_cck_c[i] =
- priv->EEPROMRfCCCKChnl1TxPwLevel[1];
- priv->tx_pwr_level_ofdm_24g_c[i] =
- priv->EEPROMRfCOfdmChnlTxPwLevel[1];
- }
- for (i = 9; i < 14; i++) {
- priv->tx_pwr_level_cck_a[i] =
- priv->EEPROMRfACCKChnl1TxPwLevel[2];
- priv->tx_pwr_level_ofdm_24g_a[i] =
- priv->EEPROMRfAOfdmChnlTxPwLevel[2];
- priv->tx_pwr_level_cck_c[i] =
- priv->EEPROMRfCCCKChnl1TxPwLevel[2];
- priv->tx_pwr_level_ofdm_24g_c[i] =
- priv->EEPROMRfCOfdmChnlTxPwLevel[2];
- }
priv->legacy_ht_tx_pwr_diff =
priv->eeprom_legacy_ht_tx_pwr_diff;
priv->antenna_tx_pwr_diff[0] = 0;
--
2.39.0