Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

[Jianhua Lu]

On Fri, Jan 20, 2023 at 11:18:56AM +0100, Krzysztof Kozlowski wrote:
> On 20/01/2023 10:47, Jianhua Lu wrote:
> > Add Kinetic KTZ8866 backlight binding documentation.
> > 
> > Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> > ---
> > Changes in v2:
> >   - Remove "items" between "compatible" and "const: kinetic,ktz8866".
> >   - Change "additionalProperties" to "unevaluatedProperties".
> > 
> > Changes in v3:
> >   - Add Krzysztof's R-b.
> > 
> > Changes in v4:
> >   - Drop Krzysztof's R-b.
> >   - Add some new properties.
> > 
> > Changes in v5:
> >   - Add missing enum under property description.
> >   - Rename uncorrect properties.
> > 
> > Changes in v6:
> >   - Correct wrong property suffix and description.
> > 
> > Changes in v7:
> >   - Add vddpos and vddeg supply.
> >   - Use enable-gpios instead of defining enable pin.
> > 
> >  .../leds/backlight/kinetic,ktz8866.yaml       | 74 +++++++++++++++++++
> >  1 file changed, 74 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > new file mode 100644
> > index 000000000000..b1d0ade0dfb6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Kinetic Technologies KTZ8866 backlight
> > +
> > +maintainers:
> > +  - Jianhua Lu <lujianhua000@xxxxxxxxx>
> > +
> > +description: |
> > +  The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks
> > +  led backlight with dual lcd bias power.
> > +  https://www.kinet-ic.com/ktz8866/
> > +
> > +allOf:
> > +  - $ref: common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: kinetic,ktz8866
> > +
> > +  vddpos-supply:
> > +    description: positive boost supply regulator.
> > +
> > +  vddneg-supply:
> > +    description: negative boost supply regulator.
> > +
> > +  enable-gpios:
> > +    description: GPIO to use to enable/disable the backlight (HWEN pin).
> > +    maxItems: 1
> > +
> > +  current-num-sinks:
> > +    description: number of the LED current sinks' channels.
> > +    enum: [1, 2, 3, 4, 5, 6]
> > +
> > +  current-ramping-time-ms:
> > +    description: LED current ramping time in milliseconds.
> > +    enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
> 
> kinetic,current-ramp-delay-ms
> 
> > +
> > +  led-ramping-time-ms:
> 
> kinetic,led-enable-ramp-delay-ms
> 
> So both are similar to existing regulator properties.
> 
reasonable suggestion.
> Best regards,
> Krzysztof
>