Re: [PATCH 1/4] dt-bindings: regulator: Describe Maxim MAX20411

From: Krzysztof Kozlowski
Date: Fri Jan 20 2023 - 03:21:50 EST


On 19/01/2023 22:47, Bjorn Andersson wrote:
> Add binding for the Maxim MAX20411 step-down DC-DC converter.
>

Subject prefix should probably be "regulator: dt-bindings: ", as per
Mark's requests.

> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> ---
> .../bindings/regulator/maxim,max20411.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml b/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
> new file mode 100644
> index 000000000000..3d1ba6139370
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/maxim,max20411.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX20411 Step-Down DC-DC Converter
> +
> +maintainers:
> + - Bjorn Andersson <andersson@xxxxxxxxxx>
> +
> +description:
> + The MAX20411 is a high-efficiency, DC-DC step-down converter. It provides
> + configurable output voltage in the range of 0.5V to 1.275V, configurable over
> + I2C.
> +
> +allOf:
> + - $ref: regulator.yaml#
> +
> +properties:
> + compatible:
> + const: maxim,max20411
> +
> + reg:
> + maxItems: 1
> +
> + enable-gpios:
> + maxItems: 1

Drop maxItems, provided by gpio-consumer-common.

> + description: GPIO connected to the EN pin, active high
> +

With two above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof