RE: [PATCH v10 4/5] dt-bindings: media: i2c: imx334 add new link_freq

[Shravan.Chippa]

Hi Kozlowski,


> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 19 January 2023 05:56 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@xxxxxxxxxxxxx>;
> paul.j.murphy@xxxxxxxxx; daniele.alessandrelli@xxxxxxxxx;
> mchehab@xxxxxxxxxx
> Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sakari Ailus
> <sakari.ailus@xxxxxx>
> Subject: Re: [PATCH v10 4/5] dt-bindings: media: i2c: imx334 add new link_freq
> 
> On 19/01/2023 12:28, shravan kumar wrote:
> > From: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC.  It might happen, that command when run on an older kernel, gives you
> outdated entries.  Therefore please be sure you base your patches on recent
> Linux kernel.
> 
> You skipped several of people/lists, so please resend.
Thanks for review, I will run the script and I will send patch.

> 
> >
> > add new supported link frequency in dt example
> 
> Start with capital letter. Finish with full stop.

I will update.

Thanks,
Shravan
> 
> >
> > Suggested-by: Sakari Ailus <sakari.ailus@xxxxxx>
> > Signed-off-by: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > index f5055b9db693..09533496b20c 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> > @@ -82,7 +82,7 @@ examples:
> >                  imx334: endpoint {
> >                      remote-endpoint = <&cam>;
> >                      data-lanes = <1 2 3 4>;
> > -                    link-frequencies = /bits/ 64 <891000000>;
> > +                    link-frequencies = /bits/ 64 <891000000
> > + 445500000>;
> >                  };
> >              };
> >          };
> 
> Best regards,
> Krzysztof