Re: [PATCH 2/2] spi: spidev: add new mediatek support

From: Mark Brown
Date: Fri Jan 20 2023 - 00:04:41 EST


On Thu, Jan 19, 2023 at 05:28:50PM +0100, Alexandre Mergnat wrote:
> Add the "mediatek,genio" compatible string to support Mediatek
> SPI controller on the genio boards.

> { .compatible = "cisco,spi-petra", .data = &spidev_of_check },
> { .compatible = "micron,spi-authenta", .data = &spidev_of_check },
> + { .compatible = "mediatek,genio", .data = &spidev_of_check },

We need a matching update to the binding document.

This does also seem like a terribly generic name - Google
suggests that this is actually a series of numbered products (eg,
Genio 700), perhaps we should be using the specific numbers here?
I guess users would care which they're talking to. It really
parses as being "generic I/O" which would be an end run around
describing the actual product though it's not actually that.

Attachment: signature.asc
Description: PGP signature