Re: [PATCH v2] KVM: x86: Replace 0-length arrays with flexible arrays

From: Sean Christopherson
Date: Thu Jan 19 2023 - 15:51:45 EST


On Wed, 18 Jan 2023 11:59:09 -0800, Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct kvm_nested_state's
> "data" union 0-length arrays with flexible arrays. (How are the
> sizes of these arrays verified?) Detected with GCC 13, using
> -fstrict-flex-arrays=3:
>
> arch/x86/kvm/svm/nested.c: In function 'svm_get_nested_state':
> arch/x86/kvm/svm/nested.c:1536:17: error: array subscript 0 is outside array bounds of 'struct kvm_svm_nested_state_data[0]' [-Werror=array-bounds=]
> 1536 | &user_kvm_nested_state->data.svm[0];
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/kvm.h:15,
> from include/linux/kvm_host.h:40,
> from arch/x86/kvm/svm/nested.c:18:
> arch/x86/include/uapi/asm/kvm.h:511:50: note: while referencing 'svm'
> 511 | struct kvm_svm_nested_state_data svm[0];
> | ^~~
>
> [...]

Applied to kvm-x86 misc, thanks! Based on the linux-next complaint, I assume
you (temporarily?) applied this to your tree as well. Holler if I've confused
you :-)

[1/1] KVM: x86: Replace 0-length arrays with flexible arrays
https://github.com/kvm-x86/linux/commit/2a8c2de0544e

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes