Re: [PATCH] ARM: dts: gta04: fix excess dma channel usage

From: Tony Lindgren
Date: Thu Jan 19 2023 - 02:30:31 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [230116 17:33]:
> * Adam Ford <aford173@xxxxxxxxx> [230116 17:00]:
> > Doesn't this imply the target-module stuff needs to be implemented for
> > the drivers? It looks like a lot of the omap3 drivers are still using
> > hwmods although some have target-modules. In this case, the mcspi
> > drivers that Andreas is disabling don't appear to have target-module
> > stuff configured.
>
> Sorry I don't remember if omap_device.c ignores status disabled or not.
> But in any case, it should be trivial to update omap3.dtsi to configure
> some of the devices like mcspi to probe with device tree data and ti-sysc
> as needed.

So as long as gta04 power management still behaves with this patch it
should good to go.

Just to note, if mcspi is at some point is updated to probe with ti-sysc,
the disabled flag needs to be kept at the mcspi child node, not at the
sysc target module level to idle the unused devices.

Regards,

Tony