Re: [PATCH 3/3] ptrace,syscall_user_dispatch: add a getter/setter for sud configuration

From: kernel test robot
Date: Wed Jan 18 2023 - 18:44:29 EST


Hi Gregory,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc4 next-20230118]
[cannot apply to tip/core/entry]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/ptrace-syscall_user_dispatch-Implement-Syscall-User-Dispatch-Suspension/20230119-041259
patch link: https://lore.kernel.org/r/20230118201055.147228-4-gregory.price%40memverge.com
patch subject: [PATCH 3/3] ptrace,syscall_user_dispatch: add a getter/setter for sud configuration
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230119/202301190722.ouyr6mLZ-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/bd6833b41ed48c444c09346f695efe229deec2e9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Gregory-Price/ptrace-syscall_user_dispatch-Implement-Syscall-User-Dispatch-Suspension/20230119-041259
git checkout bd6833b41ed48c444c09346f695efe229deec2e9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k prepare

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

In file included from include/linux/sched.h:31,
from arch/m68k/kernel/asm-offsets.c:15:
>> include/linux/syscall_user_dispatch.h:45:5: warning: no previous prototype for 'syscall_user_dispatch_get_config' [-Wmissing-prototypes]
45 | int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/syscall_user_dispatch.h:51:5: warning: no previous prototype for 'syscall_user_dispatch_set_config' [-Wmissing-prototypes]
51 | int syscall_user_dispatch_set_config(struct task_struct *task, unsigned long size,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
In file included from include/linux/sched.h:31,
from arch/m68k/kernel/asm-offsets.c:15:
>> include/linux/syscall_user_dispatch.h:45:5: warning: no previous prototype for 'syscall_user_dispatch_get_config' [-Wmissing-prototypes]
45 | int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/syscall_user_dispatch.h:51:5: warning: no previous prototype for 'syscall_user_dispatch_set_config' [-Wmissing-prototypes]
51 | int syscall_user_dispatch_set_config(struct task_struct *task, unsigned long size,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/syscall_user_dispatch_get_config +45 include/linux/syscall_user_dispatch.h

44
> 45 int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
46 void __user *data)
47 {
48 return -EINVAL;
49 }
50
> 51 int syscall_user_dispatch_set_config(struct task_struct *task, unsigned long size,
52 void __user *data)
53 {
54 return -EINVAL;
55 }
56

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests