Re: [PATCH 1/2] HID: core: Provide new max_buffer_size attribute to over-ride the default

From: Jiri Kosina
Date: Wed Jan 18 2023 - 10:00:38 EST


On Wed, 18 Jan 2023, Lee Jones wrote:

> > > Presently, when a report is processed, its size is compared solely
> > > against the value specified by user-space.
> >
> > While I am generally fine with the idea, I don't understand this sentence.
> > What exactly do you mean by 'specified by user-space'? It's defined as a
> > compile-time constant.
> >
> > > If the received report ends up being smaller than this, the
> > > remainder of the buffer is zeroed.
>
> Apologies for any ambiguity.
>
> "its size" == "compile-time constant"
>
> Would "its maximum size" read better?

I think that the confusion comes from the fact that the changelog is
written solely with the UHID usercase on mind ... ? (which is dealt with
in the independent followup patch).

Thanks,

--
Jiri Kosina
SUSE Labs