Re: [PATCH v5 0/3] Thermal ACPI APIs for generic trip points

[Daniel Lezcano]

On 18/01/2023 14:48, Zhang, Rui wrote:
> On Wed, 2023-01-18 at 10:53 +0100, Daniel Lezcano wrote:
> > Hi,
> >
> > On 13/01/2023 19:02, Daniel Lezcano wrote:
> > > Recently sent as a RFC, the thermal ACPI for generic trip points is
> > > a set of
> > > functions to fill the generic trip points structure which will
> > > become the
> > > standard structure for the thermal framework and its users.
> > >
> > > Different Intel drivers and the ACPI thermal driver are using the
> > > ACPI tables to
> > > get the thermal zone information. As those are getting the same
> > > information,
> > > providing this set of ACPI function with the generic trip points
> > > will
> > > consolidate the code.
> > >
> > > Also, the Intel PCH and the Intel 34xx drivers are converted to use
> > > the generic
> > > trip points relying on the ACPI generic trip point parsing
> > > functions.
> > >
> > > These changes have been tested on a Thinkpad Lenovo x280 with the
> > > PCH and
> > > INT34xx drivers. No regression have been observed, the trip points
> > > remain the
> > > same for what is described on this system.
> >
> > Are we ok with this series ?
> >
> > Sorry for insisting but I would like to go forward with the generic
> > thermal trip work. There are more patches pending depending on this
> > series.
>
> The whole series looks good to me.
>
> Reviwed-by: Zhang Rui <rui.zhang@xxxxxxxxx>
>
> But we'd better wait for the thermald test result from Srinvias.

Sure, thanks for the review !


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog