Re: [PATCH v3 2/2] kheaders: use standard naming for the temporary directory

From: Nicolas Schier
Date: Wed Jan 18 2023 - 03:36:20 EST


On Wed 18 Jan 2023 05:05:35 GMT, Thomas Weißschuh wrote:
> If the kheaders archive generation is interrupted then this directory
> may be left on disk and not ignored by git.
> By using the standard naming schema for temporary files and directories
> the default .gitignore and "make clean" rules will apply.
>
> Suggested-by: Nicolas Schier <nicolas@xxxxxxxxx>
> Suggested-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> ---
> kernel/gen_kheaders.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
> index 473036b43c83..b477b763f262 100755
> --- a/kernel/gen_kheaders.sh
> +++ b/kernel/gen_kheaders.sh
> @@ -7,7 +7,7 @@ set -e
> sfile="$(readlink -f "$0")"
> outdir="$(pwd)"
> tarfile=$1
> -cpio_dir=$outdir/$tarfile.tmp
> +cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
>
> dir_list="
> include/
>
> --
> 2.39.1

Thanks!

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>
Tested-by: Nicolas Schier <nicolas@xxxxxxxxx>

Attachment: signature.asc
Description: PGP signature