Re: [PATCHv2] mm: use stack_depot_early_init for kmemleak

From: Zhaoyang Huang
Date: Tue Jan 17 2023 - 20:49:36 EST


On Wed, Jan 18, 2023 at 9:40 AM Zhaoyang Huang <huangzhaoyang@xxxxxxxxx> wrote:
>
> On Wed, Jan 18, 2023 at 9:31 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, 18 Jan 2023 09:25:48 +0800 Zhaoyang Huang <huangzhaoyang@xxxxxxxxx> wrote:
> >
> > > On Wed, Jan 18, 2023 at 8:17 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > >
> > > > On Tue, 17 Jan 2023 16:11:52 +0800 "zhaoyang.huang" <zhaoyang.huang@xxxxxxxxxx> wrote:
> > > >
> > > > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc.
> > > > > Solve this by having stackdepot use stack_depot_early_init. Extra Kconfig also
> > > > > done by moving kmemleak stuff to mm/Kconfig.debug.
> > > >
> > > > I don't understand - what was the reason for the Kconfig change?
> > > The items related to kmemleak are moved from lib/Kconfig.debug to
> > > mm/Kconfig.debug
> >
> > Well yes, but why?
> It was suggested by Vlastimil in a previous comment. It makes more
> sense to have kmemleak's source code and Kconfig items under the same
> directory.
> >
> > Is that related to this bug fix? If not then please let's have that
> > change in a separate patch.
> The moved items are updated for this bug fix.
sorry for my faint. I will make another patch for Kconfig changes.
> >