Re: [PATCH v6 5/8] cxl/mem: Trace Memory Module Event Record

From: Ira Weiny
Date: Tue Jan 17 2023 - 20:17:40 EST


Jonathan Cameron wrote:
> On Mon, 09 Jan 2023 11:42:24 -0800
> Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
>
> > CXL rev 3.0 section 8.2.9.2.1.3 defines the Memory Module Event Record.
> >
> > Determine if the event read is memory module record and if so trace the
> > record.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> Typo inline. With that fixed
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> > index b6321cfb1d9f..ebb4c8ce8587 100644
> > --- a/drivers/cxl/core/trace.h
> > +++ b/drivers/cxl/core/trace.h
> > @@ -439,6 +439,149 @@ TRACE_EVENT(cxl_dram,
> > )
> > );
> >
> > +/*
> > + * Memory Module Event Record - MMER
> > + *
> > + * CXL res 3.0 section 8.2.9.2.1.3; Table 8-45
> > + */
> > +#define CXL_MMER_HEALTH_STATUS_CHANGE 0x00
> > +#define CXL_MMER_MEDIA_STATUS_CHANGE 0x01
> > +#define CXL_MMER_LIFE_USED_CHANGE 0x02
> > +#define CXL_MMER_TEMP_CHANGE 0x03
> > +#define CXL_MMER_DATA_PATH_ERROR 0x04
> > +#define CXL_MMER_LAS_ERROR 0x05
>
> CXL_MMER_LSA_ERROR

Done.

Thanks,
Ira