Re: [PATCH v4 04/19] irqdomain: Fix association race

From: Thomas Gleixner
Date: Tue Jan 17 2023 - 18:35:28 EST


On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote:
> The sanity check for an already mapped virq was done outside of the

s/was/is/

> irq_domain_mutex-protected section which meant that an (unlikely) racing

s/meant/means/

> association may not be detected.

You describe the status quo and then correctly what the fix is:

> Fix this by factoring out the association implementation, which will
> also be used in follow-on changes to rework the locking.

Otherwise your fix fixes something which existed in the past, no?

Thanks,

tglx