Re: [PATCH] scsi: stex: fix MU_MAX_DELAY typecheck

From: Bart Van Assche
Date: Tue Jan 17 2023 - 12:56:11 EST


On 1/17/23 08:38, Arnd Bergmann wrote:
@@ -173,7 +173,7 @@ enum {
ST_ADDITIONAL_MEM_MIN = 0x80000,
PMIC_SHUTDOWN = 0x0D,
PMIC_REUMSE = 0x10,
- ST_IGNORED = -1,
+ ST_IGNORED = -1u,
ST_NOTHANDLED = 7,
ST_S3 = 3,
ST_S4 = 4,

From drivers/scsi/stex.c:

int st_sleep_mic;

... st_sleep_mic == ST_IGNORED ...

Can changing ST_IGNORED from signed to unsigned break the stex driver?

Thanks,

Bart.