Re: [PATCH v3 3/4] thermal/drivers/intel_powerclamp: Use powercap idle-inject framework

[Daniel Lezcano]

On 17/01/2023 15:49, Rafael J. Wysocki wrote:
> On Tue, Jan 17, 2023 at 12:16 PM Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx> wrote:
> > On 17/01/2023 03:07, Srinivas Pandruvada wrote:
> >
> > [ ... ]
> >
> > > diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> > > index f0c845679250..6c2a95f41c81 100644
> > > --- a/drivers/thermal/intel/Kconfig
> > > +++ b/drivers/thermal/intel/Kconfig
> > > @@ -3,6 +3,8 @@ config INTEL_POWERCLAMP
> > >        tristate "Intel PowerClamp idle injection driver"
> > >        depends on X86
> > >        depends on CPU_SUP_INTEL
> > > +     select POWERCAP
> > > +     select IDLE_INJECT
> >
> > Just a question, not a comment. As IDLE_INJECT depends on POWERCAP, is
> > it necessary to select POWERCAP also here ?
>
> Yes, it is.
>
> If IDLE_INJECT alone is selected, POWERCAP may not be and there will
> be a broken dependency.

Ok, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog