Re: [PATCH v6 2/3] dt-bindings: remoteproc: ti: Add new compatible for AM62 SoC family

From: Raghavendra, Vignesh
Date: Tue Jan 17 2023 - 09:49:34 EST


Hi Devarsh,

On 1/17/2023 10:54 AM, Devarsh Thakkar wrote:
> Hi Krzysztof,
>
> On 17/01/23 00:36, Krzysztof Kozlowski wrote:
>> On 16/01/2023 16:19, Devarsh Thakkar wrote:
>>> AM62 family of devices don't have a R5F cluster, instead
>>> they have single core DM R5F.
>>> Add new compatible string ti,am62-r5fss to support this scenario.
>>>
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions. However, there's no need to repost patches *only* to add the
>> tags. The upstream maintainer will do that for acks received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
> I apologize if it was not clear but yes I didn't put the tag as
> patch was updated to use cluster-mode=3 for am62x as per review comments on
> https://lore.kernel.org/all/20230110183505.GA2741090@p14s/

It would be helpful in future if you document why tag was dropped as
part of change log (below tearline) to indicate its intentional.

>
> I'll append a note below commit message on Reviewed-By
> removal when I post the next series.

> Regards
> Devarsh
>>
>>
>> Best regards,
>> Krzysztof
>>