Re: [PATCH V2 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default()

[Andrzej Pietrasiewicz]

Hi again,

W dniu 17.01.2023 o 15:13, Andrzej Pietrasiewicz pisze:
> Hi,
>
> W dniu 16.01.2023 o 16:55, Jon Hunter pisze:
> > The function gether_setup_name_default() is called by various USB
> > ethernet gadget drivers. This function always generates the MAC address
> > for the ethernet gadget device and always prints a warning when
> > generating the MAC address. Given that these messages are expected, make
> > these debug prints instead of warnings.

Actually, I have second thoughts about this commit message.
If the messages were expected, why would you change them?

I think that just as in PATCH V2 1/1, there's an implicit context required
to understand your commit message: it answers the question "why don't we
just remove these messages altogether?" Answer: "because they might be expected
by some guys, so let's keep them".

IMO, what _is_ expected is random selection of addresses. So, something on
the lines of this would look better to me:

"Randomly selecting host and device MAC addresses is a proper and expected
default behavior. A properly working driver should be silent, so don't warn
the user about default MAC addresses selection happening and convert the
warnings into debug messages."

> > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>
> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>

With the above taken into account I uphold my R-b tag.

Andrzej

> > ---
> > V1 -> V2: Changed print to debug instead of info.
> >
> >   drivers/usb/gadget/function/u_ether.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/function/u_ether.c 
> > b/drivers/usb/gadget/function/u_ether.c
> > index be8e7b448933..8feb40e38137 100644
> > --- a/drivers/usb/gadget/function/u_ether.c
> > +++ b/drivers/usb/gadget/function/u_ether.c
> > @@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char 
> > *netname)
> >       snprintf(net->name, sizeof(net->name), "%s%%d", netname);
> >       eth_random_addr(dev->dev_mac);
> > -    pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
> > +    pr_debug("using random self ethernet address %pM\n", dev->dev_mac);
> >       /* by default we always have a random MAC address */
> >       net->addr_assign_type = NET_ADDR_RANDOM;
> >       eth_random_addr(dev->host_mac);
> > -    pr_warn("using random host ethernet address %pM\n", dev->host_mac);
> > +    pr_debug("using random host ethernet address %pM\n", dev->host_mac);
> >       net->netdev_ops = &eth_netdev_ops;