Re: [PATCH 0/4] Device tree support for Hyper-V VMBus driver

From: Rob Herring
Date: Tue Jan 17 2023 - 09:35:44 EST


On Mon, Jan 16, 2023 at 08:48:04AM -0800, Saurabh Sengar wrote:
> This patch set expands the functionality of the VMBus driver by adding
> support for device tree on x86/x64 architectures.

Humm, interesting. Currently we support OLPC and CE4100 for x86 DT based
systems. Adding a new platform implies numerous new bindings yet there
is only 1 here. I'm guessing your DT is generated by the hypervisor, but
an example would be nice to see and run thru dtschema validation. We've
unfortunately been trying to fix KVM/QEMU DT years after it was created.


> The first two patches enable Hyper-V builds for non-ACPI systems, while
> the third patch adds device tree support into the VMBus driver, in
> addition to its pre-existing support for ACPI. The fourth patch includes
> the necessary device tree bindings for the VMBus driver.

Bindings come before using them...

>
> Saurabh Sengar (4):
> drivers/clocksource/hyper-v: non ACPI support in hyperv clock
> Drivers: hv: allow non ACPI compilation for
> hv_is_hibernation_supported
> Drivers: hv: vmbus: Device Tree support
> dt-bindings: hv: Add dt-bindings for VMBus
>
> .../devicetree/bindings/hv/msft,vmbus.yaml | 34 ++++
> drivers/clocksource/hyperv_timer.c | 15 +-
> drivers/hv/hv_common.c | 4 +
> drivers/hv/vmbus_drv.c | 190 +++++++++++++++++----
> 4 files changed, 206 insertions(+), 37 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hv/msft,vmbus.yaml
>
> --
> 1.8.3.1
>