Re: [PATCH v1 2/3] gpio: pcf857x: Make use of device properties

[Linus Walleij]

On Mon, Jan 16, 2023 at 1:46 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Add mod_devicetable.h include.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

LGTM:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> -       of_property_read_u32(np, "lines-initial-states", &n_latch);
> +       device_property_read_u32(&client->dev, "lines-initial-states", &n_latch);

Haha we even managed to sneak in an official property for this,
I don't know when that happened but very good to have, this
is the first time I see it used actually.

Now I will recommend everyone with this problem to just
follow the PCF857x example.

Yours,
Linus Walleij