Re: [PATCH] remoteproc: imx_dsp_rproc: add module parameter to ignore ready flag from remote processor

[Iuliana Prodan]

On 1/17/2023 9:36 AM, S.J. Wang wrote:
> > There are cases when we want to test a simple "hello world"
> > application on the DSP and we don't have IPC between the cores.
> > Therefore, skip the wait for remote processor to start.
> >
> > Added "ignoreready" flag while inserting the module to ignore remote
> > processor reply after start.
> > By default, this is off - do not ignore reply from rproc.
> >
> > Signed-off-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> > ---
> >   drivers/remoteproc/imx_dsp_rproc.c | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_dsp_rproc.c
> > b/drivers/remoteproc/imx_dsp_rproc.c
> > index 95da1cbefacf..ec298f8b019f 100644
> > --- a/drivers/remoteproc/imx_dsp_rproc.c
> > +++ b/drivers/remoteproc/imx_dsp_rproc.c
> > @@ -26,9 +26,20 @@
> >   #include "remoteproc_elf_helpers.h"
> >   #include "remoteproc_internal.h"
> >
> > +#define IMX_DSP_IGNORE_REMOTE_READY		0
> > +
> > +/*
> > + * Module parameters
> > + */
> > +static unsigned int imx_dsp_rproc_ignoreready =
> > +IMX_DSP_IGNORE_REMOTE_READY; module_param_named(ignoreready,
> > +imx_dsp_rproc_ignoreready, int, 0644); MODULE_PARM_DESC(ignoreready,
> > +		 "Ignore remote proc reply after start, default is 0 (off).");
> > +
> >   #define DSP_RPROC_CLK_MAX			5
> >
> >   #define REMOTE_IS_READY				BIT(0)
> > +#define REMOTE_SKIP_WAIT			BIT(31)
> Can we use a close bit with REMOTE_IS_READY,  like BIT(1)?

Sure, I'll send a v2.

Thanks,

Iulia