Re: [patch V3 16/22] genirq/msi: Provide new domain id based interfaces for freeing interrupts

From: Thomas Gleixner
Date: Mon Jan 16 2023 - 14:22:14 EST


David!

On Mon, Jan 16 2023 at 18:58, David Woodhouse wrote:

> On Mon, 2023-01-16 at 19:11 +0100, Thomas Gleixner wrote:
>> +       .flags                  = MSI_FLAG_FREE_MSI_DESCS | MSI_FLAG_DEV_SYSFS,
>  
> That doesn't apply on top of
> https://lore.kernel.org/all/4bffa69a949bfdc92c4a18e5a1c3cbb3b94a0d32.camel@xxxxxxxxxxxxx/
> and doesn't include the | MSI_FLAG_PCI_MSIX either.

Indeed. I saw that patch after my reply. :)

> With that remedied,
>
> Tested-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Albeit only under qemu with
> https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv
> and not under real Xen.

Five levels of emulation. What could possibly go wrong?