Re: [Patch v1 09/10] memory: tegra: get number of enabled mc channels

From: Thierry Reding
Date: Mon Jan 16 2023 - 11:43:13 EST


On Fri, Jan 13, 2023 at 08:34:18PM +0530, Sumit Gupta wrote:
>
>
> On 22/12/22 17:07, Krzysztof Kozlowski wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On 20/12/2022 17:02, Sumit Gupta wrote:
> > > Get number of MC channels which are actually enabled
> > > in current boot configuration.
> >
> > Why? You don't do anything with it. Commit msg should give the reason of
> > changes.
> >
> >
> > Best regards,
> > Krzysztof
> >
>
> CPU OPP tables have per channel bandwidth info. The "mc->num_channels" is
> used in [1] (Patch v1 10/10) to make the per MC channel bandwidth requested
> by the CPU cluster as a multiple of number of the enabled mc channels.
>
> Will update the commit description with this info.
>
> [1] https://lore.kernel.org/lkml/20221220160240.27494-1-sumitg@xxxxxxxxxx/T/#m3ac150a86977e89b97c5d19c60384f29d7a01d21

Both patch 9 and 10 are reasonably small, so it would be okay to merge
the two patches and avoid any need for an extra explanation.

Thierry

Attachment: signature.asc
Description: PGP signature