RE: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks addition

From: Quan, Evan
Date: Sun Jan 15 2023 - 21:27:57 EST


[AMD Official Use Only - General]

Series is reviewed-by: Evan Quan <evan.quan@xxxxxxx>

> -----Original Message-----
> From: Deepak R Varma <drv@xxxxxxxxx>
> Sent: Sunday, January 15, 2023 3:16 PM
> To: Quan, Evan <Evan.Quan@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; David
> Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx>; Praveen Kumar
> <kumarpraveen@xxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks
> addition
>
> The patch series proposes usage of bitwise or "|" operator for addition of
> bitmasks instead of using numerial additions. The former is quicker and
> cleaner.
>
> The proposed change is compile tested.
>
> Deepak R Varma (3):
> drm/amd/pm/powerplay/smumgr: use bitwise or for addition
> drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition
> drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks addition
>
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++---
> -
> drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +-
> drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +-
> drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>
>