Re: [PATCH v4] sh: avoid using IRQ0 on SH3/4

[Geert Uytterhoeven]

Hi Adrian,

On Fri, Jan 13, 2023 at 7:49 PM John Paul Adrian Glaubitz
<glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Jan 13, 2023, at 7:27 PM, Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
> >> On 5/3/22 11:42 PM, Sergey Shtylyov wrote:
> >> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
> >> and even now, when IRQ0 is about to be returned by platfrom_get_irq(), you
> >> see a big warning.  The code supporting SH3/4 SoCs maps the IRQ #s starting
> >> at 0 -- modify that code to start the IRQ #s from 16 instead.
> >>
> >> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they
> >> indeed use IRQ0 for the SMSC911x compatible Ethernet chip...
> >>
> >> [1] https://lore.kernel.org/all/025679e1-1f0a-ae4b-4369-01164f691511@xxxxxx/
> >>
> >> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >> Tested-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> >>
> >> ---
> >> The patch is against Linus Torvalds' 'linux.git' repo.
> >
> >   So, this patch hasn't been merged... may I ask why? :-(
>
> The SH maintainers have been MIA which is why the other maintainers want to kill the architecture again.
>
> I’m seriously considering adopting the architecture.
>
> Not sure whether Linus would grant that though.

Why not?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds