Re: [PATCH] iommu/ipmmu-vmsa: Remove ipmmu_utlb_disable()

From: Jason Gunthorpe
Date: Fri Jan 13 2023 - 14:12:34 EST


On Fri, Jan 13, 2023 at 07:56:40PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
>
> The function is unused after commit 1b932ceddd19 ("iommu:
> Remove detach_dev callbacks") and so compilation fails with
>
> drivers/iommu/ipmmu-vmsa.c:305:13: error: ‘ipmmu_utlb_disable’ defined but not used [-Werror=unused-function]
> 305 | static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain,
> | ^~~~~~~~~~~~~~~~~~
>
> Remove the function to fix the compile error.
>
> Fixes: 1b932ceddd19 ("iommu: Remove detach_dev callbacks")
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> ---
> drivers/iommu/ipmmu-vmsa.c | 12 ------------
> 1 file changed, 12 deletions(-)

I'm surprised the 0-day bot didn't notice?

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason