Re: [PATCH v5 03/10] mfd: intel-m10-bmc: Split into core and spi specific parts

From: Lee Jones
Date: Fri Jan 13 2023 - 09:56:51 EST


On Mon, 26 Dec 2022, Ilpo Järvinen wrote:

> Split the common code from intel-m10-bmc driver into intel-m10-bmc-core
> and move the SPI bus parts into an interface specific file.
>
> intel-m10-bmc-core becomes the core MFD functions which can support
> multiple bus interface like SPI bus.
>
> Co-developed-by: Tianfei zhang <tianfei.zhang@xxxxxxxxx>
> Signed-off-by: Tianfei zhang <tianfei.zhang@xxxxxxxxx>
> Reviewed-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> # hwmon
> Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 2 +-
> drivers/fpga/Kconfig | 2 +-
> drivers/hwmon/Kconfig | 2 +-
> drivers/mfd/Kconfig | 30 ++--
> drivers/mfd/Makefile | 4 +-
> drivers/mfd/intel-m10-bmc-core.c | 122 +++++++++++++++++
> .../{intel-m10-bmc.c => intel-m10-bmc-spi.c} | 128 +++---------------
> include/linux/mfd/intel-m10-bmc.h | 6 +
> 8 files changed, 172 insertions(+), 124 deletions(-)
> create mode 100644 drivers/mfd/intel-m10-bmc-core.c
> rename drivers/mfd/{intel-m10-bmc.c => intel-m10-bmc-spi.c} (59%)

Looks okay:

For my own reference (apply this as-is to your sign-off block):

Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx>

--
Lee Jones [李琼斯]