Re: [PATCH v2 2/7] dt-bindings: watchdog: qcom-wdt: do not allow fallback alone

From: Guenter Roeck
Date: Fri Jan 13 2023 - 09:06:07 EST


On Fri, Jan 13, 2023 at 11:33:41AM +0100, Krzysztof Kozlowski wrote:
> The compatible "qcom,kpss-wdt" is too generic and should not be used
> alone. Mark it as deprecated when not prepended by specific compatible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> Changes since v1:
> 1. Add tag.
> ---
> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index e76364c52fc7..3e0b30a817d6 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -31,9 +31,10 @@ properties:
> - qcom,apss-wdt-sm8150
> - qcom,apss-wdt-sm8250
> - const: qcom,kpss-wdt
> + - const: qcom,kpss-wdt
> + deprecated: true
> - items:
> - enum:
> - - qcom,kpss-wdt
> - qcom,kpss-timer
> - qcom,kpss-wdt-apq8064
> - qcom,kpss-wdt-ipq8064
> --
> 2.34.1
>