Re: [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support

[Devi Priya]

On 1/13/2023 7:19 PM, Marc Zyngier wrote:
> On 2023-01-10 12:13, devi priya wrote:
> > From: POOVENDHAN SELVARAJ <quic_poovendh@xxxxxxxxxxx>
> >
> > Add initial device tree support for Qualcomm IPQ9574 SoC
> > and AL02 board
> >
> > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Co-developed-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > Signed-off-by: POOVENDHAN SELVARAJ <quic_poovendh@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile            |   1 +
> >  arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts |  69 ++++
> >  arch/arm64/boot/dts/qcom/ipq9574.dtsi        | 318 +++++++++++++++++++
> >  3 files changed, 388 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/ipq9574.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile
> > b/arch/arm64/boot/dts/qcom/Makefile
> > index 3e79496292e7..872c62028a0b 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM)    += ipq6018-cp01-c1.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += ipq8074-hk01.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += ipq8074-hk10-c1.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += ipq8074-hk10-c2.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)    += ipq9574-al02-c7.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += msm8916-alcatel-idol347.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += msm8916-asus-z00l.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)    += msm8916-huawei-g7.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> > b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> > new file mode 100644
> > index 000000000000..ae3c32f3e16a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
>
> [...]
>
> > +    timer {
> > +        compatible = "arm,armv8-timer";
> > +        interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +                 <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +                 <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +                 <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | 
> > IRQ_TYPE_LEVEL_LOW)>;
>
> Interesting choice for the PPIs...
>
> > +        clock-frequency = <24000000>;
>
> Please drop this and fix the firmware. No system built within
> past 10 years should need it.
Sure, will drop!
>          M.
Best Regards,
Devi Priya