Re: [PATCH v3 net-next 1/1] plca.c: fix obvious mistake in checking retval

From: Eric Dumazet
Date: Fri Jan 13 2023 - 08:38:57 EST


On Fri, Jan 13, 2023 at 2:26 PM Piergiorgio Beruto
<piergiorgio.beruto@xxxxxxxxx> wrote:
>
> Revert a wrong fix that was done during the review process. The
> intention was to substitute "if(ret < 0)" with "if(ret)".
> Unfortunately, the intended fix did not meet the code.
> Besides, after additional review, it was decided that "if(ret < 0)"
> was actually the right thing to do.
>
> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@xxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>