Re: [PATCH 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

[Devi Priya]

On 1/11/2023 3:16 PM, Krzysztof Kozlowski wrote:
> On 10/01/2023 13:13, devi priya wrote:
> > Add pinctrl definitions for the TLMM of IPQ9574
> >
> > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   drivers/pinctrl/qcom/Kconfig           |   10 +
> >   drivers/pinctrl/qcom/Makefile          |    1 +
> >   drivers/pinctrl/qcom/pinctrl-ipq9574.c | 1003 ++++++++++++++++++++++++
> >   3 files changed, 1014 insertions(+)
> >   create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq9574.c
> >
> > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> > index 1378ddca084f..a9b4b07e3de0 100644
> > --- a/drivers/pinctrl/qcom/Kconfig
> > +++ b/drivers/pinctrl/qcom/Kconfig
> > @@ -70,6 +70,16 @@ config PINCTRL_IPQ6018
> >   	  Qualcomm Technologies Inc. IPQ6018 platform. Select this for
> >   	  IPQ6018.
> >   
> > +config PINCTRL_IPQ9574
> > +	tristate "Qualcomm Technologies, Inc. IPQ9574 pin controller driver"
> > +	depends on GPIOLIB && OF
>
> Look at other entries and use similar style.
Sure, will do!
> Best regards,
> Krzysztof
Best Regards,
Devi Priya