Re: [PATCH] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting

From: Wolfram Sang
Date: Fri Jan 13 2023 - 06:15:26 EST



> > + regmap_update_bits(rpc->regmap, RPCIF_PHYCNT,
> > + RPCIF_PHYCNT_STRTIM(rpc->info->strtim),
> > + RPCIF_PHYCNT_STRTIM(rpc->info->strtim));
>
> I'm not sure this is guaranteed to work, as using rpc->info->strtim as
> the mask may not clear all bits (e.g. on R-Car M3-W it is 6, not 7), and
> the initial values of the bits are documented to be undefined.

Okay, thanks! I will fix this.

Attachment: signature.asc
Description: PGP signature