Re: [PATCH -next V14 4/7] riscv: entry: Convert to generic entry

From: Conor Dooley
Date: Fri Jan 13 2023 - 04:29:56 EST


Hey Guo Ren,

On Thu, Jan 12, 2023 at 04:58:45AM -0500, guoren@xxxxxxxxxx wrote:
> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> This patch converts riscv to use the generic entry infrastructure from
> kernel/entry/*. The generic entry makes maintainers' work easier and
> codes more elegant. Here are the changes:
>
> - More clear entry.S with handle_exception and ret_from_exception
> - Get rid of complex custom signal implementation
> - Move syscall procedure from assembly to C, which is much more
> readable.
> - Connect ret_from_fork & ret_from_kernel_thread to generic entry.
> - Wrap with irqentry_enter/exit and syscall_enter/exit_from_user_mode
> - Use the standard preemption code instead of custom
>
> Suggested-by: Huacai Chen <chenhuacai@xxxxxxxxxx>
> Reviewed-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
> Tested-by: Yipeng Zou <zouyipeng@xxxxxxxxxx>
> Tested-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> Cc: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

Unfortunately from this patch onwards, the !MMU build is broken.
Should be able to reproduce it with nommu_virt_defconfig.

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature