Re: [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address

[neil . armstrong]

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Node names should be generic and use hyphens instead of underscores to
> not cause warnings. Also nodes without a reg property should not have a
> unit-address. Change the scpi_dvfs node to use clock-controller as node
> name without a unit address (since it does not have a reg property).
>
> Fixes: 70db166a2baa ("ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> ---
> changes from v1 -> v2:
> - new patch
>
>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index f8b115cd6775..a79a35e84281 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -250,7 +250,7 @@ scpi {
>   		scpi_clocks: clocks {
>   			compatible = "arm,scpi-clocks";
>   
> -			scpi_dvfs: scpi_clocks@0 {
> +			scpi_dvfs: clock-controller {
>   				compatible = "arm,scpi-dvfs-clocks";
>   				#clock-cells = <1>;
>   				clock-indices = <0>;

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>