Re: [PATCH v5] x86/sev: Add SEV-SNP guest feature negotiation support

From: Nikunj A. Dadhania
Date: Fri Jan 13 2023 - 00:31:30 EST




On 12/01/23 20:12, Tom Lendacky wrote:
> On 1/12/23 02:41, Nikunj A Dadhania wrote:
>> +
>> +        if (sev_es_get_ghcb_version() < 2 ||
>
> I would just use ghcb_version directly here.

Right, that will work.

> But if you really want a function, that should be a pre-patch that also updates the other areas that directly use ghcb_version.

There is only one such reference other than this one, will use ghcb_version directly.

Regards
Nikunj