Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI

[Arnd Bergmann]

On Thu, Jan 12, 2023, at 20:58, Hawkins, Nick wrote:

> The updated section of the device tree will be:
>
> ahb@80000000 {
>                         compatible = "simple-bus";
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges = <0x0 0x80000000 0xf000000>, /* 
> 0x80000000 - 0x8f000000 */
>                                  <0x40000000 0xc0000000 0x40000000>; /* 
> 0xc0000000 - 0xffffffff */
>                         dma-ranges;

Ok

>
>                       ...
>
>                        vic0: interrupt-controller@4eff0000 { /* 0xceff0000 */
>                                 compatible = "arm,pl192-vic";
>                                 reg = <0x4eff0000 0x1000>;
>                                 interrupt-controller;
>                                 #interrupt-cells = <1>;
>                         };
>
>                         vic1: interrupt-controller@f00000 { /* 0x80f00000 */
>                                 compatible = "arm,pl192-vic";
>                                 reg = <0xf00000 0x1000>;
>                                 interrupt-controller;
>                                 #interrupt-cells = <1>;
>                         };

I still don't see the value of the /* 0x80f00000 */ comments,
you should define the ranges to the most sensible mapping
based on the datasheet so you don't need the comments.

If the datasheet uses a bus-local address (0xf00000), then
just get rid of the comment, since that only adds confusion.
OTOH if the 0x80f00000 number is what is in the datasheet,
then adjust the ranges to do a 1:1 mapping of the registers
on the bus and use that address directly.

      Arnd